From 8073d0044bda502dc3dd169ee3839d2a84bdb491 Mon Sep 17 00:00:00 2001 From: Morten Olsen Date: Fri, 12 Dec 2025 11:54:32 +0100 Subject: [PATCH] chore: improved delete logging --- internal/controller/nucleiscan_controller.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/internal/controller/nucleiscan_controller.go b/internal/controller/nucleiscan_controller.go index a0cfccb..be2898a 100644 --- a/internal/controller/nucleiscan_controller.go +++ b/internal/controller/nucleiscan_controller.go @@ -140,16 +140,19 @@ func (r *NucleiScanReconciler) handleDeletion(ctx context.Context, nucleiScan *n log := logf.FromContext(ctx) if controllerutil.ContainsFinalizer(nucleiScan, finalizerName) { - log.Info("Handling deletion, performing cleanup") + log.Info("Handling deletion, performing cleanup", "name", nucleiScan.Name, "namespace", nucleiScan.Namespace) // Perform any cleanup here (e.g., cancel running scans) // In our synchronous implementation, there's nothing to clean up // Remove finalizer + log.Info("Removing finalizer", "finalizer", finalizerName) controllerutil.RemoveFinalizer(nucleiScan, finalizerName) if err := r.Update(ctx, nucleiScan); err != nil { + log.Error(err, "Failed to remove finalizer", "name", nucleiScan.Name, "namespace", nucleiScan.Namespace) return ctrl.Result{}, err } + log.Info("Finalizer removed successfully", "name", nucleiScan.Name, "namespace", nucleiScan.Namespace) } return ctrl.Result{}, nil